PHWinfo banniere

Titres
PORTAIL ANNUAIRE ARTICLES COMPARATEUR HÉBERGEURS DEVIS FORUMS RÉDUCTEUR D'URL
Précédent   PHWinfo > Autres forums > Forum Programmation & Conception > comp.lang.c > How to send dynamic vector?
S'inscrire FAQ Membres Recherche Messages du jour Marquer les forums comme lus
How to send dynamic vector?

Réponse
 
LinkBack Outils de la discussion
Vieux 21/10/2007, 20h45   #1 (permalink)
dopiotr
Aucun Avatar
 
Messages: n/a
Hébergeur:
Par défaut How to send dynamic vector?

Hello Group,

int Msg[size];
MPI_Send(Msg, size, MPI_INT, DEST, TAG, MPI_COMM_WORLD);
this is working fine.

But how to send Msg declared like this:
int *Msg=(int*)malloc(sizeof(int)*size);

It gives me
p4_error: interrupt SIGSEGV: 11
not_send: could not write to fd=4, errno = 32

Thanks!

  Réponse avec citation
Vieux 21/10/2007, 20h56   #2 (permalink)
santosh
Aucun Avatar
 
Messages: n/a
Hébergeur:
Par défaut Re: How to send dynamic vector?

dopiotr wrote:

> Hello Group,
>
> int Msg[size];
> MPI_Send(Msg, size, MPI_INT, DEST, TAG, MPI_COMM_WORLD);
> this is working fine.
>
> But how to send Msg declared like this:
> int *Msg=(int*)malloc(sizeof(int)*size);
>
> It gives me
> p4_error: interrupt SIGSEGV: 11
> not_send: could not write to fd=4, errno = 32


Without further code I can't really tell what your problem is. It may
not be a C problem but an incorrect use of MPI functions. You might do
better to ask in a forum dedicated to your MPI implementation.

<http://en.wikipedia.org/wiki/Message_Passing_Interface>
<http://www.mpi-forum.org/docs/>
<http://www.open-mpi.org/>
<http://www.personal.leeds.ac.uk/~bgy1mm/MPITutorial/MPIHome.html>

  Réponse avec citation
Vieux 21/10/2007, 21h03   #3 (permalink)
CryptiqueGuy
Aucun Avatar
 
Messages: n/a
Hébergeur:
Par défaut Re: How to send dynamic vector?

On Oct 22, 12:45 am, dopiotr <nos...@nospam.invalid> wrote:
> Hello Group,
>
> int Msg[size];
> MPI_Send(Msg, size, MPI_INT, DEST, TAG, MPI_COMM_WORLD);
> this is working fine.
>
> But how to send Msg declared like this:
> int *Msg=(int*)malloc(sizeof(int)*size);
>


Did u check the return value of malloc?
It might be NULL, due to failed memory allocation.

  Réponse avec citation
Vieux 21/10/2007, 21h06   #4 (permalink)
dopiotr
Aucun Avatar
 
Messages: n/a
Hébergeur:
Par défaut Re: How to send dynamic vector?

On 21 Oct 2007 at 19:56, santosh wrote:
> dopiotr wrote:
>
>> Hello Group,
>>
>> int Msg[size];
>> MPI_Send(Msg, size, MPI_INT, DEST, TAG, MPI_COMM_WORLD);
>> this is working fine.
>>
>> But how to send Msg declared like this:
>> int *Msg=(int*)malloc(sizeof(int)*size);
>>
>> It gives me
>> p4_error: interrupt SIGSEGV: 11
>> not_send: could not write to fd=4, errno = 32

>
> Without further code I can't really tell what your problem is. It may
> not be a C problem but an incorrect use of MPI functions. You might do
> better to ask in a forum dedicated to your MPI implementation.
>
><http://en.wikipedia.org/wiki/Message_Passing_Interface>
><http://www.mpi-forum.org/docs/>
><http://www.open-mpi.org/>
><http://www.personal.leeds.ac.uk/~bgy1mm/MPITutorial/MPIHome.html>
>


Working wersion:
#include "mpi.h"
#include<stdio.h>
#include<stdlib.h>
uint n_sigm;
float *suma_sigm;

void main(int c, char *v[])
{
int size,rank;
int j;
float *s_tmp;
MPI_Init(&c,&v);
MPI_Comm_size(MPI_COMM_WORLD,&size);
MPI_Comm_rank(MPI_COMM_WORLD,&rank);
n_sigm=1000;

suma_sigm=(float *)malloc(sizeof(float)*n_sigm);
s_tmp=(float *)malloc(sizeof(float)*n_sigm);//difference

if(rank != 0)
{
for(j=0;j<n_sigm;j++)
suma_sigm[j]=rank*1000+j;
}
else
{
for(j=0;j<n_sigm;j++)
s_tmp[j]=0;
}
MPI_Reduce(suma_sigm,s_tmp ,n_sigm,MPI_FLOAT,MPI_SUM,
0,MPI_COMM_WORLD);
if( rank == 0 )
for(j=0;j<n_sigm;j++)
printf("%i %f\n",j,s_tmp[j]);
free(suma_sigm);
free(s_tmp);
MPI_Finalize();
}

Why it is not working:
#include "mpi.h"
#include<stdio.h>
#include<stdlib.h>
uint n_sigm;
float *suma_sigm;
int main(int c, char *v[])
{
int size,rank;
int j;
float *s_tmp;
MPI_Init(&c,&v);
MPI_Comm_size(MPI_COMM_WORLD,&size);
MPI_Comm_rank(MPI_COMM_WORLD,&rank);
n_sigm=1000;

suma_sigm=(float *)malloc(sizeof(float)*n_sigm);

if(rank != 0)
{
for(j=0;j<n_sigm;j++)
suma_sigm[j]=rank*1000+j;
}
else
{
for(j=0;j<n_sigm;j++)
s_tmp[j]=0;
}
s_tmp=(float *)malloc(sizeof(float)*n_sigm);//difference
MPI_Reduce(suma_sigm,s_tmp ,n_sigm,MPI_FLOAT,MPI_SUM,
0,MPI_COMM_WORLD);
if( rank == 0 )
for(j=0;j<n_sigm;j++)
printf("%i %f\n",j,s_tmp[j]);
free(suma_sigm);
free(s_tmp);
MPI_Finalize();
}

And why value of s_tmp[0] & s_tmp[1] is incorrect (in working
version).

  Réponse avec citation
Vieux 21/10/2007, 21h22   #5 (permalink)
santosh
Aucun Avatar
 
Messages: n/a
Hébergeur:
Par défaut Re: How to send dynamic vector?

dopiotr wrote:

> On 21 Oct 2007 at 19:56, santosh wrote:
>> dopiotr wrote:
>>
>>> Hello Group,
>>>
>>> int Msg[size];
>>> MPI_Send(Msg, size, MPI_INT, DEST, TAG, MPI_COMM_WORLD);
>>> this is working fine.
>>>
>>> But how to send Msg declared like this:
>>> int *Msg=(int*)malloc(sizeof(int)*size);
>>>
>>> It gives me
>>> p4_error: interrupt SIGSEGV: 11
>>> not_send: could not write to fd=4, errno = 32

>>
>> Without further code I can't really tell what your problem is. It may
>> not be a C problem but an incorrect use of MPI functions. You might
>> do better to ask in a forum dedicated to your MPI implementation.
>>
>><http://en.wikipedia.org/wiki/Message_Passing_Interface>
>><http://www.mpi-forum.org/docs/>
>><http://www.open-mpi.org/>
>><http://www.personal.leeds.ac.uk/~bgy1mm/MPITutorial/MPIHome.html>
>>

>
> Working wersion:
> #include "mpi.h"
> #include<stdio.h>
> #include<stdlib.h>
> uint n_sigm;
> float *suma_sigm;
>
> void main(int c, char *v[])


Use int main

> {
> int size,rank;
> int j;
> float *s_tmp;
> MPI_Init(&c,&v);
> MPI_Comm_size(MPI_COMM_WORLD,&size);
> MPI_Comm_rank(MPI_COMM_WORLD,&rank);
> n_sigm=1000;
>
> suma_sigm=(float *)malloc(sizeof(float)*n_sigm);
> s_tmp=(float *)malloc(sizeof(float)*n_sigm);//difference


In C the cast of malloc's return value is not needed. I'd write your
statements as:

suma_sigm = malloc(sizeof *suma_sigm * n_sigm);
s_tmp = malloc(sizeof *s_tmp * n_sigm);

Also be sure to check that malloc actually succeeded.

> if(rank != 0)
> {
> for(j=0;j<n_sigm;j++)
> suma_sigm[j]=rank*1000+j;
> }
> else
> {
> for(j=0;j<n_sigm;j++)
> s_tmp[j]=0;
> }
> MPI_Reduce(suma_sigm,s_tmp ,n_sigm,MPI_FLOAT,MPI_SUM,
> 0,MPI_COMM_WORLD);
> if( rank == 0 )
> for(j=0;j<n_sigm;j++)
> printf("%i %f\n",j,s_tmp[j]);
> free(suma_sigm);
> free(s_tmp);
> MPI_Finalize();


Return a value here.

> }
>
> Why it is not working:
> #include "mpi.h"
> #include<stdio.h>
> #include<stdlib.h>
> uint n_sigm;
> float *suma_sigm;
> int main(int c, char *v[])
> {
> int size,rank;
> int j;
> float *s_tmp;
> MPI_Init(&c,&v);
> MPI_Comm_size(MPI_COMM_WORLD,&size);
> MPI_Comm_rank(MPI_COMM_WORLD,&rank);
> n_sigm=1000;
>
> suma_sigm=(float *)malloc(sizeof(float)*n_sigm);
>
> if(rank != 0)
> {
> for(j=0;j<n_sigm;j++)
> suma_sigm[j]=rank*1000+j;
> }
> else
> {
> for(j=0;j<n_sigm;j++)
> s_tmp[j]=0;


Well, here s_tmp is not yet pointing to any valid memory. You're writing
to memory you don't own or should not be writing to. Initialise s_tmp
to a valid object or an array of objects before using it.

> }
> s_tmp=(float *)malloc(sizeof(float)*n_sigm);//difference


/Now/ you're doing it, but it's too late, unless rank was not zero.

> MPI_Reduce(suma_sigm,s_tmp ,n_sigm,MPI_FLOAT,MPI_SUM,
> 0,MPI_COMM_WORLD);
> if( rank == 0 )
> for(j=0;j<n_sigm;j++)
> printf("%i %f\n",j,s_tmp[j]);
> free(suma_sigm);
> free(s_tmp);
> MPI_Finalize();
> }
>
> And why value of s_tmp[0] & s_tmp[1] is incorrect (in working
> version).


How should I know? What value did you expect? The obvious bug waiting to
happen in your second version is the use of the pointer s_tmp without
making it point to anything valid beforehand.


  Réponse avec citation
Vieux 21/10/2007, 22h24   #6 (permalink)
Barry Schwarz
Aucun Avatar
 
Messages: n/a
Hébergeur:
Par défaut Re: How to send dynamic vector?

On Oct 21, 1:06 pm, dopiotr <nos...@nospam.invalid> wrote:

snip

> > dopiotr wrote:

>
> >> Hello Group,

>
> >> int Msg[size];
> >> MPI_Send(Msg, size, MPI_INT, DEST, TAG, MPI_COMM_WORLD);
> >> this is working fine.

>
> >> But how to send Msg declared like this:
> >> int *Msg=(int*)malloc(sizeof(int)*size);

>
> >> It gives me
> >> p4_error: interrupt SIGSEGV: 11
> >> not_send: could not write to fd=4, errno = 32


snip

> Working wersion:


This is not a working version. It invokes undefined behavior and you
state it produces incorrect results.

> #include "mpi.h"
> #include<stdio.h>
> #include<stdlib.h>
> uint n_sigm;
> float *suma_sigm;
>
> void main(int c, char *v[])


main should return int.

> {
> int size,rank;
> int j;
> float *s_tmp;
> MPI_Init(&c,&v);
> MPI_Comm_size(MPI_COMM_WORLD,&size);
> MPI_Comm_rank(MPI_COMM_WORLD,&rank);
> n_sigm=1000;
>
> suma_sigm=(float *)malloc(sizeof(float)*n_sigm);


Do not cast the return from malloc. It can never and the only
effect would be to suppress a diagnostic you really want to see if it
applies to your code.

> s_tmp=(float *)malloc(sizeof(float)*n_sigm);//difference


You should always check that malloc succeeds.

>
> if(rank != 0)
> {
> for(j=0;j<n_sigm;j++)
> suma_sigm[j]=rank*1000+j;
> }
> else
> {
> for(j=0;j<n_sigm;j++)
> s_tmp[j]=0;
> }


At this point, the elements of suma_sigm or s_tmp (but not both) have
been assigned values. The elements of the other array are
indeterminate (uninitialized).

> MPI_Reduce(suma_sigm,s_tmp ,n_sigm,MPI_FLOAT,MPI_SUM,
> 0,MPI_COMM_WORLD);


Since you don't pass rank to this function, how is it supposed to
determine which of the arrays has valid values and which doesn't. Any
attempt by the function to evaluate an indeterminate element will
invoke undefined behavior.

> if( rank == 0 )
> for(j=0;j<n_sigm;j++)
> printf("%i %f\n",j,s_tmp[j]);
> free(suma_sigm);
> free(s_tmp);
> MPI_Finalize();
>
> }
>
> Why it is not working:
> #include "mpi.h"
> #include<stdio.h>
> #include<stdlib.h>
> uint n_sigm;
> float *suma_sigm;
> int main(int c, char *v[])
> {
> int size,rank;
> int j;
> float *s_tmp;
> MPI_Init(&c,&v);
> MPI_Comm_size(MPI_COMM_WORLD,&size);
> MPI_Comm_rank(MPI_COMM_WORLD,&rank);
> n_sigm=1000;
>
> suma_sigm=(float *)malloc(sizeof(float)*n_sigm);
>
> if(rank != 0)
> {
> for(j=0;j<n_sigm;j++)
> suma_sigm[j]=rank*1000+j;
> }
> else
> {
> for(j=0;j<n_sigm;j++)
> s_tmp[j]=0;


At this point, s_tmp is still indeterminate; it does not yet point to
any memory you can access. s_tmp[j] does not exist. This invokes
undefined behavior.

> }
> s_tmp=(float *)malloc(sizeof(float)*n_sigm);//difference


And if the previous undefined behavior were not sufficient, this would
replace the address that s_tmp was pointing to with the address of the
newly allocated memory making all the elements of the array
indeterminate again.

> MPI_Reduce(suma_sigm,s_tmp ,n_sigm,MPI_FLOAT,MPI_SUM,
> 0,MPI_COMM_WORLD);
> if( rank == 0 )
> for(j=0;j<n_sigm;j++)
> printf("%i %f\n",j,s_tmp[j]);
> free(suma_sigm);
> free(s_tmp);
> MPI_Finalize();
>
> }
>
> And why value of s_tmp[0] & s_tmp[1] is incorrect (in working
> version).


By definition, a working version would produce correct results. What
is the vlaue of rank when you see these incorrect values? What is the
function MPI_Reduce supposed to do with the two arrays you pass?

  Réponse avec citation
Vieux 21/10/2007, 22h35   #7 (permalink)
Malcolm McLean
Aucun Avatar
 
Messages: n/a
Hébergeur:
Par défaut Re: How to send dynamic vector?


"dopiotr" <nospam@nospam.invalid> wrote in message
> Hello Group,
>
> int Msg[size];
> MPI_Send(Msg, size, MPI_INT, DEST, TAG, MPI_COMM_WORLD);
> this is working fine.
>
> But how to send Msg declared like this:
> int *Msg=(int*)malloc(sizeof(int)*size);
>
> It gives me
> p4_error: interrupt SIGSEGV: 11
> not_send: could not write to fd=4, errno = 32
>

Should be fine. If the call sends a static array it should work exactly the
same way with a dynamic buffer allocated with malloc(). This is a general
feature of C functions, not just MPI.

However you have to know the message length, and allocate another buffer, to
receive the message at the other end.

--
Free games and programming goodies.
http://www.personal.leeds.ac.uk/~bgy1mm


  Réponse avec citation
Vieux 21/10/2007, 23h04   #8 (permalink)
Tor Rustad
Aucun Avatar
 
Messages: n/a
Hébergeur:
Par défaut Re: How to send dynamic vector?

dopiotr wrote:
> Hello Group,
>
> int Msg[size];
> MPI_Send(Msg, size, MPI_INT, DEST, TAG, MPI_COMM_WORLD);
> this is working fine.
>
> But how to send Msg declared like this:
> int *Msg=(int*)malloc(sizeof(int)*size);


Have you included <stdlib.h>? We recommend dropping the cast, and write
this:

int *Msg = malloc(sizeof(int)*size);

> It gives me
> p4_error: interrupt SIGSEGV: 11
> not_send: could not write to fd=4, errno = 32


MPI related questions are off-topic here, try

comp.parallel.mpi


--
Tor <torust [at] online [dot] no>

"Technical skill is mastery of complexity, while creativity is mastery
of simplicity"
  Réponse avec citation
Réponse


Outils de la discussion

Règles de messages
Vous ne pouvez pas créer de nouvelles discussions
Vous ne pouvez pas envoyer des réponses
Vous ne pouvez pas envoyer des pièces jointes
Vous ne pouvez pas modifier vos messages

Les balises BB sont activées : oui
Les smileys sont activés : oui
La balise [IMG] est activée : oui
Le code HTML peut être employé : non
Trackbacks are oui
Pingbacks are oui
Refbacks are oui


Fuseau horaire GMT +1. Il est actuellement 03h45.


Édité par : vBulletin® version 3.7.2
Copyright ©2000 - 2008, Jelsoft Enterprises Ltd.
Search Engine Friendly URLs by vBSEO 3.2.0 RC5 Tous droits réservés.
Version française #16 par l'association vBulletin francophone
PHWinfo est un site Éducation Sans Frontières
Ad Management by RedTyger
©Tous droits réservés par les parties respectives
Page generated in 0,16843 seconds with 16 queries