Afficher un message
Vieux 15/09/2007, 04h30   #9
Rik Wasmus
Aucun Avatar
 
Messages: n/a
Hébergeur:
Par défaut Re: My readdir and display images snippet - Thanks

On Fri, 14 Sep 2007 23:42:46 +0200, Confused but working on it
<PostInGroups@wherever.com> wrote:

> On 2007-09-13 08:10:48 -0700, Captain Paralytic <paul_lautman@yahoo.com>
> said:
>
>> On 12 Sep, 17:50, Confused but working on it
>> <PostInGro...@wherever.com> wrote:
>>> Just wanted to say thanks for the posts ing me make ths work. Added
>>> a few comments and after the readdir used a pattern match to test for
>>> .jpg, and seems to work fine on my test setup. Maybe I should test for
>>> gif, tiff, and png... Anyway, here's the code:
>>> <?php
>>> //Open images directory
>>> $dir = opendir("images");
>>> //read files in the dir
>>> while (($file = readdir($dir)) !== false)
>>> //test to make sure jpg
>>> if (eregi("\.jpg",$file))
>>> {
>>> echo "<img src='images/$file' class=\"pad1em\">";


Hmm, are you sure about the class name? I'd say that on a new layout with
the same HTML 'pad1em' could end up making very little sense. A golden
rule of css is that a classname should reflect what something is, not how
it is _displayed. A more suitable name could be something like
'imagepreview' or the like.

>>> }
>>> closedir($dir);
>>> ?>
>>> For my next trick I'm going to change the above to read a thumbs dir,
>>> and make a link to a larger picture of the same name in images.
>>> Shouldn't be too hard bt my last programming class was almost 20 years
>>> ago. Hats off to everyone that does this for a living.
>>> Thanks again!

>> I think that your ereg might find files such as fred.jpgs.php

>
> Yo Captain! (ex-nick of mine)
>
> So that will never be found because fred and I, well, his wife will tell
> you the whole story...
>
> Just like a million other peeps I take pictures. I load em up in my mac
> in iPhoto, make an album with the corresponding name and don't include
> shats that were crappy. Export to a dir called images, filezilla to my
> site. Use my little code to display on a page. I tried iWeb to make
> pages, gallery databases done in php, and holy cow way to complicated.
> Just easier to manage everything in directories by some kind of topic.
>
> So is there a way for your exampe to happen?


Oh yeah.
(Just make sure the file is a proper image directly after an upload.
Examining extention or mime-type is no good. I'm quite happy to us
getimagesize() for this purpose, as it would return false if it couldn't
interpret a file as an image.)

And to display only files _ending_ in jp(e)g, I'd use
preg_match('/\.jpe?g$/i',$string);
--
Rik Wasmus
  Réponse avec citation
 
Page generated in 0,05621 seconds with 9 queries